[midend] Move insertZeroConstantOp from dip-utils to utils.

buddy-compiler · Sep 22, 2023 · da71b6b · da71b6b
1 parent 07a8970
commit da71b6b
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 30 deletions.
diff --git a/midend/include/Utils/DIPUtils.h b/midend/include/Utils/DIPUtils.h
@@ -38,11 +38,6 @@ enum class DIP_OP { CORRELATION_2D, EROSION_2D, DILATION_2D };
 // from lowering passes with appropriate messages.
 enum class DIP_ERROR { INCONSISTENT_TYPES, UNSUPPORTED_TYPE, NO_ERROR };
 
-// Inserts a constant op with value 0 into a location `loc` based on type
-// `type`. Supported types are : f32, f64, integer types.
-Value insertZeroConstantOp(MLIRContext *ctx, OpBuilder &builder, Location loc,
-                           Type elemTy);
-
 // Inserts FMA operation into a given location `loc` based on type `type`.
 // Note: FMA is done by Multiply and Add for integer types, because there is no
 // dedicated FMA operation for them.

diff --git a/midend/include/Utils/Utils.h b/midend/include/Utils/Utils.h
@@ -25,6 +25,11 @@ using namespace mlir;
 
 namespace buddy {
 
+// Inserts a constant op with value 0 into a location `loc` based on type
+// `type`. Supported types are : f32, f64, integer types.
+Value insertZeroConstantOp(MLIRContext *ctx, OpBuilder &builder, Location loc,
+                           Type elemTy);
+
 // Function to test whether a value is equivalent to zero or not.
 Value zeroCond(OpBuilder &builder, Location loc, Type elemType, Value value,
                Value zeroElem);

diff --git a/midend/lib/Conversion/LowerDIP/LowerDIPPass.cpp b/midend/lib/Conversion/LowerDIP/LowerDIPPass.cpp
@@ -795,8 +795,7 @@ class DIPTopHat2DOpLowering : public OpRewritePattern<dip::TopHat2DOp> {
     VectorType vectorTy32 = VectorType::get({stride}, inElemTy);
     IntegerType i1 = IntegerType::get(ctx, 1);
     VectorType vectorMaskTy = VectorType::get({stride}, i1);
-    Value zeroPaddingElem =
-        dip::insertZeroConstantOp(ctx, rewriter, loc, inElemTy);
+    Value zeroPaddingElem = insertZeroConstantOp(ctx, rewriter, loc, inElemTy);
     Value zeroPaddingVec =
         rewriter.create<vector::BroadcastOp>(loc, vectorTy32, zeroPaddingElem);
 
@@ -1001,8 +1000,7 @@ class DIPBottomHat2DOpLowering : public OpRewritePattern<dip::BottomHat2DOp> {
     VectorType vectorTy32 = VectorType::get({stride}, inElemTy);
     IntegerType i1 = IntegerType::get(ctx, 1);
     VectorType vectorMaskTy = VectorType::get({stride}, i1);
-    Value zeroPaddingElem =
-        dip::insertZeroConstantOp(ctx, rewriter, loc, inElemTy);
+    Value zeroPaddingElem = insertZeroConstantOp(ctx, rewriter, loc, inElemTy);
     Value zeroPaddingVec =
         rewriter.create<vector::BroadcastOp>(loc, vectorTy32, zeroPaddingElem);
 
@@ -1203,8 +1201,7 @@ class DIPMorphGrad2DOpLowering : public OpRewritePattern<dip::MorphGrad2DOp> {
     VectorType vectorTy32 = VectorType::get({stride}, inElemTy);
     IntegerType i1 = IntegerType::get(ctx, 1);
     VectorType vectorMaskTy = VectorType::get({stride}, i1);
-    Value zeroPaddingElem =
-        dip::insertZeroConstantOp(ctx, rewriter, loc, inElemTy);
+    Value zeroPaddingElem = insertZeroConstantOp(ctx, rewriter, loc, inElemTy);
     Value zeroPaddingVec =
         rewriter.create<vector::BroadcastOp>(loc, vectorTy32, zeroPaddingElem);
 

diff --git a/midend/lib/Utils/DIPUtils.cpp b/midend/lib/Utils/DIPUtils.cpp
@@ -184,25 +184,6 @@ DIP_ERROR checkDIPCommonTypes(DIPOP op, const std::vector<Value> &args) {
   return DIP_ERROR::NO_ERROR;
 }
 
-// Inserts a constant op with value 0 into a location `loc` based on type
-// `type`. Supported types are : f32, f64, integer types.
-Value insertZeroConstantOp(MLIRContext *ctx, OpBuilder &builder, Location loc,
-                           Type elemTy) {
-  Value op = {};
-  auto bitWidth = elemTy.getIntOrFloatBitWidth();
-  if (elemTy.isF32() || elemTy.isF64()) {
-    FloatType type =
-        elemTy.isF32() ? FloatType::getF32(ctx) : FloatType::getF64(ctx);
-    auto zero = APFloat::getZero(type.getFloatSemantics());
-    op = builder.create<arith::ConstantFloatOp>(loc, zero, type);
-  } else if (elemTy.isInteger(bitWidth)) {
-    IntegerType type = IntegerType::get(ctx, bitWidth);
-    op = builder.create<arith::ConstantIntOp>(loc, 0, type);
-  }
-
-  return op;
-}
-
 // Inserts FMA operation into a given location `loc` based on type `type`.
 // Note: FMA is done by Multiply and Add for integer types, because there is no
 // dedicated FMA operation for them.

diff --git a/midend/lib/Utils/Utils.cpp b/midend/lib/Utils/Utils.cpp
@@ -39,6 +39,25 @@ using namespace mlir;
 
 namespace buddy {
 
+// Inserts a constant op with value 0 into a location `loc` based on type
+// `type`. Supported types are : f32, f64, integer types.
+Value insertZeroConstantOp(MLIRContext *ctx, OpBuilder &builder, Location loc,
+                           Type elemTy) {
+  Value op = {};
+  auto bitWidth = elemTy.getIntOrFloatBitWidth();
+  if (elemTy.isF32() || elemTy.isF64()) {
+    FloatType type =
+        elemTy.isF32() ? FloatType::getF32(ctx) : FloatType::getF64(ctx);
+    auto zero = APFloat::getZero(type.getFloatSemantics());
+    op = builder.create<arith::ConstantFloatOp>(loc, zero, type);
+  } else if (elemTy.isInteger(bitWidth)) {
+    IntegerType type = IntegerType::get(ctx, bitWidth);
+    op = builder.create<arith::ConstantIntOp>(loc, 0, type);
+  }
+
+  return op;
+}
+
 // Function to test whether a value is equivalent to zero or not.
 Value zeroCond(OpBuilder &builder, Location loc, Type elemType, Value value,
                Value zeroElem) {