[frontend]: add install target for frontend headers #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meshtag
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Why not put this in the parent directory CMakeLists.txt?
That feels like a good place for project-wide operations, like building everything and then installing stuff globally.
|
Ok I will fix it up and amend to the previous commit. |
This can benefit downstream projects by allowing them to easily include headers from a distributed installation. Signed-off-by: Avimitin <[email protected]>
Avimitin
force-pushed
the
install-headers
branch
from
1522078 to
72aab1e
Compare
meshtag
approved these changes
Dec 7, 2023
Avimitin
added a commit
that referenced
this pull request
Dec 11, 2023
This can benefit downstream projects by allowing them to easily include headers from a distributed installation. Signed-off-by: Avimitin <[email protected]>
taiqzheng
pushed a commit
to taiqzheng/buddy-mlir
that referenced
this pull request
Dec 26, 2023
This can benefit downstream projects by allowing them to easily include headers from a distributed installation. Signed-off-by: Avimitin <[email protected]>
ShiHaoGao
pushed a commit
to ShiHaoGao/buddy-mlir
that referenced
this pull request
Oct 18, 2024
This can benefit downstream projects by allowing them to easily include headers from a distributed installation. Signed-off-by: Avimitin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can benefit downstream projects by allowing them to easily include headers from a distributed installation.