Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Fix stand-alone conv-opt edge detection build #257

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

meshtag
Copy link
Member

@meshtag meshtag commented Dec 7, 2023

I was getting an error saying that cmake was not able to find the target buddy-image-container-test when I was trying to have a stand-alone build of the edge-detection example for testing conv-opt.

This patch should fix that problem and users should be able to build edge-detection target without building any DIP target first.

@meshtag meshtag requested a review from zhanghb97 December 7, 2023 13:51
@meshtag meshtag added enhancement New feature or request DIP labels Dec 7, 2023
@meshtag meshtag changed the title Fix stand-alone conv-opt edge detection build [examples] Fix stand-alone conv-opt edge detection build Dec 7, 2023
Copy link
Member

@zhanghb97 zhanghb97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhanghb97 zhanghb97 merged commit d31b868 into buddy-compiler:main Dec 11, 2023
1 check passed
@meshtag meshtag deleted the fix_edge_detction_target branch December 11, 2023 13:45
taiqzheng pushed a commit to taiqzheng/buddy-mlir that referenced this pull request Dec 26, 2023
ShiHaoGao pushed a commit to ShiHaoGao/buddy-mlir that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DIP enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants