Migrate to use com.vanniktech.maven.publish #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the buf-gradle-plugin build to use the `com.vanniktech.maven.publish` plugin instead of the `io.github.gradle-nexus.publish-plugin`. Move all of the build configuration into `build.gradle.kts` and update CI workflows to migrate off deprecated GitHub actions and action inputs.
pkwarren
commented
Jun 28, 2024
| @@ -21,17 +21,17 @@ jobs: | |||
| with: | |||
| fetch-depth: 0 | |||
| - name: Validate Gradle wrapper | |||
| uses: gradle/wrapper-validation-action@v3 | |||
| uses: gradle/actions/wrapper-validation@v3 | |||
| - name: Build | ||
| uses: gradle/gradle-build-action@v3 | ||
| with: | ||
| arguments: build --info |
There was a problem hiding this comment.
| @@ -40,14 +40,14 @@ jobs: | |||
| comment_mode: off | |||
| check_name: "Test Results (Ubuntu)" | |||
| - name: Publish unit test results (Windows) | |||
| uses: EnricoMi/publish-unit-test-result-action/composite@v2 | |||
| uses: EnricoMi/publish-unit-test-result-action/windows@v2 | |||
There was a problem hiding this comment.
| ./gradlew | ||
| publishToMavenCentral | ||
| publishPlugins | ||
| --no-configuration-cache |
There was a problem hiding this comment.
| ORG_GRADLE_PROJECT_mavenCentralUsername: ${{ secrets.SONATYPE_USER }} | ||
| ORG_GRADLE_PROJECT_mavenCentralPassword: ${{ secrets.SONATYPE_PASSWORD }} | ||
| ORG_GRADLE_PROJECT_signingInMemoryKey: ${{ secrets.GPG_KEY_ARMORED }} | ||
| ORG_GRADLE_PROJECT_signingInMemoryKeyPassword: ${{ secrets.GPG_PASSPHRASE }} |
There was a problem hiding this comment.
| @@ -61,7 +69,42 @@ kotlin { | |||
| } | |||
| } | |||
|
|
|||
| mavenPublishing { | |||
| publishToMavenCentral(SonatypeHost.S01) | |||
There was a problem hiding this comment.
@rubensf - This is what we would change if we wanted to publish to central instead of s01.
rubensf
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the buf-gradle-plugin build to use the
com.vanniktech.maven.publishplugin instead of theio.github.gradle-nexus.publish-plugin. Move all of the build configuration intobuild.gradle.ktsand update CI workflows to migrate off deprecated GitHub actions and action inputs.