Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test using v1 lint config with inter-module dependencies that must run on Buf 1.31.0 #239

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Add test using v1 lint config with inter-module dependencies that must run on Buf 1.31.0 #239

merged 5 commits into from
Sep 20, 2024

Conversation

andrewparmet
Copy link
Collaborator

@andrewparmet andrewparmet commented Sep 20, 2024 •
edited
Loading

This PR introduces a test that passes with Buf pinned to 1.31.0 but fails when on latest. The failure with newer versions of Buf is:

     * What went wrong:
    Execution failed for task ':bufLint'.
    > Some Protobuf files had lint violations:
      src-main-proto/buf/test/v1/test.proto:20:8:import "protokt/protokt.proto": file does not exist

@andrewparmet andrewparmet mentioned this pull request Sep 20, 2024
Open
@andrewparmet andrewparmet changed the title Add broken test using v1 config Add test using v1 lint config with inter-module dependencies that must run on Buf 1.31.0 Sep 20, 2024
@andrewparmet andrewparmet merged commit c3014a1 into main Sep 20, 2024
10 checks passed
@andrewparmet andrewparmet deleted the add-broken-test-with-v1-config branch September 20, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkwarren pkwarren pkwarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewparmet @pkwarren