Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buf unable to build image when dependencies use conflicting extension numbers #2688

Closed
aparmet-toast opened this issue Dec 25, 2023 · 2 comments

Comments

@aparmet-toast
Copy link

Is it possible to ignore, during buf build, an error when two dependencies declare an extension with the same number? Here's an example error message:

buf/test/v1/test.proto:23:14:extension with tag 1072 for message google.protobuf.MessageOptions already defined at validate/validate.proto:17:29

In this case, validate/validate.proto, which is owned by Envoy, has used an extension number reserved for another project. If my project depends on both of these, then it's not possible to build a Buf image containing all the protos unless there's some way to ignore the conflict.

For context, I'm working on the buf-gradle-plugin, specifically attempting to address the issue that my PR codifies: bufbuild/buf-gradle-plugin#171

@bufdev
Copy link
Member

bufdev commented Dec 27, 2023

Conflicting extension numbers is something that should be a core compilation error - we shouldn't adjust this in the compiler, protoc would fail as well. It's no different than conflicting field numbers in the view of the Protobuf language. Envoy really should get this one fixed (fortunately or unfortunately).

@aparmet-toast
Copy link
Author

Oh well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants