Add test codifying behavior when two modules reuse the same extension number #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e extension number
andrewparmet
commented
Dec 24, 2023
| @@ -1,7 +1,7 @@ | |||
| buildscript { repositories { gradlePluginPortal() } } | |||
|
|
|||
| plugins { | |||
| id("net.vivin.gradle-semantic-build-versioning") version "4.0.0" | |||
| id("io.alcide.gradle-semantic-build-versioning") version "4.2.2" | |||
There was a problem hiding this comment.
I was having trouble running Gradle locally. This fixed the issue and is the spiritual successor to the unmaintained original plugin we use currently.
There was a problem hiding this comment.
I don't have experience with this plugin, but since it is now a fork of a fork we may encounter future ownership issues again at some point.
andrewparmet
changed the title
andrewparmet
changed the title
andrewparmet
changed the title
pkwarren
approved these changes
Jan 2, 2024
| @@ -1,7 +1,7 @@ | |||
| buildscript { repositories { gradlePluginPortal() } } | |||
|
|
|||
| plugins { | |||
| id("net.vivin.gradle-semantic-build-versioning") version "4.0.0" | |||
| id("io.alcide.gradle-semantic-build-versioning") version "4.2.2" | |||
There was a problem hiding this comment.
I don't have experience with this plugin, but since it is now a fork of a fork we may encounter future ownership issues again at some point.
|
It looks like this isn't something that will be configurable in Buf: bufbuild/buf#2688 But I'm going to merge this anyways since it's good to nail it down in case this does ever change. |
andrewparmet
deleted the
buf-build-given-resource-that-reuses-extension-number
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning the process of addressing envoyproxy/java-control-plane#296.
The plugin should be able to be configured to ignore these conflicts since the user is not in control of the bad actor dependency.
The failing tests are due to user-level failure, but in principle (and this is what happened) one may have dependencies that conflict and there's nothing you can do.