Skip to content

Commit

Permalink
Move googlecloudplatform/bq-schema-api to semver sync strategy (#780)
Browse files Browse the repository at this point in the history
Checked old vs new manifest, the only change is the readme:

```diff
diff --git manifest-old manifest-new
index 2d494fa..8cb10e9 100644
--- a/manifest-old
+++ b/manifest-new
@@ -1,5 +1,5 @@
 shake256:a9c4ad5b20a2946a25d5efb7f096b32ffaa567e3e9a7d89984870104aab45f08d7f6f10c7c72affdc4aabab0471066958ae97c3bb5925b7cb268f8afde27ebbf  LICENSE
 shake256:6385cd1572194e79fda22944dc9c6b1e016b7e9ed89aae6e3cdd200b6860e14a3a413997d97289c64c6920ca90288caf84358ebde9ddeedcefa5988f254e90e0  bq_field.proto
 shake256:af879ba44c229924a4f5ddecf9b4c13fcecf8b91152182f8b71cfea876e619aacae4948e2adc1cf6fc8da8439a072d0b66ceede415fd8a231cc9052a5317b4e5  bq_table.proto
-shake256:436e280640e101852352a4ae1d8ee788781086dfb4652016fb35aa954999d018f1c43809be3789bdf4e6e699725d246c1142977d0ddfe2003c685d3c08ca3dd6  buf.md
+shake256:28541d181d024f941fccd08aa71cab6a5a7c95f4c6c9fc96650c86fc0792538647ccb2f1609ddff99c26fec77bad87290edbbac3d8cb93f0025c67900af5b2ce  buf.md
 shake256:29427569a8fb1e77c04ceeb5c7a2cbba8d5a3cccc300d24b6abde1208b00ad10e22e22d6ee9ae0720651e28383a70f552572ab0bf5ebd2ea93895621a619dccb  buf.yaml
```

Link to [SemVer release
v2.0](https://github.com/GoogleCloudPlatform/protoc-gen-bq-schema/releases/tag/v2.0)

Fixes #592
  • Loading branch information
unmultimedio authored Nov 26, 2024
1 parent dedad16 commit 0499957
Show file tree
Hide file tree
Showing 11 changed files with 12 additions and 99 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/fetch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ jobs:
title: "Found new managed modules references"
body: |
New managed modules references found. Please review.
- [ ] `googlecloudplatform/bq-schema-api` has updates, I have checked https://github.com/bufbuild/modules/issues/592
team-reviewers: bufbuild/bsr-team
token: ${{ steps.generate_token.outputs.token }}
- uses: dblock/create-a-github-issue@c5e54b8762a0c4c2cd9330750e30b81bcc369c38
Expand Down
6 changes: 3 additions & 3 deletions modules/static/googlecloudplatform/bq-schema-api/buf.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

Updates to the [source repository](https://github.com/GoogleCloudPlatform/protoc-gen-bq-schema) are
automatically synced on a periodic basis, and each BSR commit is tagged with corresponding Git
commits.
semver releases.

To depend on a specific Git commit, you can use it as your reference in your dependencies:

```
```yaml
deps:
- buf.build/googlecloudplatform/bq-schema-api:<GIT_COMMIT_TAG>
- buf.build/googlecloudplatform/bq-schema-api:<SEMVER_RELEASE_VERSION>
```
For more information, see the [documentation](https://buf.build/docs/bsr/overview).
2 changes: 1 addition & 1 deletion modules/static/googlecloudplatform/bq-schema-api/initref
Original file line number Diff line number Diff line change
@@ -1 +1 @@
31a7e43419f7c19d79de0bb506798bc602287e80
v2.0

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

This file was deleted.

This file was deleted.

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 2 additions & 14 deletions modules/sync/googlecloudplatform/bq-schema-api/state.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,8 @@
{
"references": [
{
"name": "31a7e43419f7c19d79de0bb506798bc602287e80",
"digest": "41efb5a2e1001dde031d0f3dcc429cd7fc47d2808ae3b23cd951c594067a21ff246b9bfcb291af55fcb3764322de88bc5ae6c0304e812b31dc2082582e6e2e75"
},
{
"name": "100bba852d378cfdb36ad2f2cb0d21cbb3664371",
"digest": "41efb5a2e1001dde031d0f3dcc429cd7fc47d2808ae3b23cd951c594067a21ff246b9bfcb291af55fcb3764322de88bc5ae6c0304e812b31dc2082582e6e2e75"
},
{
"name": "87c8132ab25acc2b174178e2f4279e569c0b5628",
"digest": "95d3a63191c6972257cbdcf08d315e923f5e61b40a2ef7feec9c5aba1f2116e1b94926cb65ab908634229227086ffe10c2a8c34c7a24a0fc3dfc8773bdea30f4"
},
{
"name": "78b6998919e338fec9f4a251bc334d69e030e118",
"digest": "95d3a63191c6972257cbdcf08d315e923f5e61b40a2ef7feec9c5aba1f2116e1b94926cb65ab908634229227086ffe10c2a8c34c7a24a0fc3dfc8773bdea30f4"
"name": "v2.0",
"digest": "a72cb483d3e1b71402bb4fb8edec8e39c981b5edcd4259a49c223bc058adbb234f3f44c49128069ec82b16d3dd27991ed77f030f6250f6a28d023c23d4c7ddb5"
}
]
}
2 changes: 1 addition & 1 deletion modules/sync/state.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
},
{
"module_name": "googlecloudplatform/bq-schema-api",
"latest_reference": "78b6998919e338fec9f4a251bc334d69e030e118"
"latest_reference": "v2.0"
},
{
"module_name": "grpc-ecosystem/grpc-gateway",
Expand Down
3 changes: 1 addition & 2 deletions scripts/fetch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,7 @@ sync_references releases gogo protobuf https://github.com/gogo/protobuf
sync_references releases google cel-spec https://github.com/google/cel-spec proto
sync_references commits googleapis googleapis https://github.com/googleapis/googleapis
sync_references releases googlechrome lighthouse https://github.com/GoogleChrome/lighthouse proto
# TODO: move googlecloudplatform/bq-schema-api to releases in their next semver release
sync_references commits googlecloudplatform bq-schema-api https://github.com/GoogleCloudPlatform/protoc-gen-bq-schema
sync_references releases googlecloudplatform bq-schema-api https://github.com/GoogleCloudPlatform/protoc-gen-bq-schema
sync_references commits grpc grpc https://github.com/grpc/grpc-proto
sync_references releases grpc-ecosystem grpc-gateway https://github.com/grpc-ecosystem/grpc-gateway
sync_references releases opencensus opencensus https://github.com/census-instrumentation/opencensus-proto src
Expand Down

0 comments on commit 0499957

Please sign in to comment.