Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for strict conformance with Editions #226

Merged
merged 1 commit into from
Jul 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixes for strict conformance with Editions
jchadwick-buf committed Jul 17, 2024

Verified

This commit was signed with the committer’s verified signature.
squid233 squid233
commit a45cd7f06887c380fdc5f5627f831fa9f31e9cbf
Original file line number Diff line number Diff line change
@@ -306,7 +306,7 @@ func ignoreEmptySuite() suites.Suite {
},
"proto/2023/message/explicit_presence/length_prefixed/zero": suites.Case{
Message: &cases.IgnoreEmptyEditionsMessageExplicitPresence{Val: &cases.IgnoreEmptyEditionsMessageExplicitPresence_Msg{}},
Expected: results.Violations(&validate.Violation{FieldPath: "val", ConstraintId: "ignore_empty.proto2.message"}),
Expected: results.Violations(&validate.Violation{FieldPath: "val", ConstraintId: "ignore_empty.editions.message"}),
},
"proto/2023/message/explicit_presence/length_prefixed/unset": suites.Case{
Message: &cases.IgnoreEmptyEditionsMessageExplicitPresence{},
@@ -318,7 +318,7 @@ func ignoreEmptySuite() suites.Suite {
},
"proto/2023/message/explicit_presence/delimited/zero": suites.Case{
Message: &cases.IgnoreEmptyEditionsMessageExplicitPresenceDelimited{Val: &cases.IgnoreEmptyEditionsMessageExplicitPresenceDelimited_Msg{}},
Expected: results.Violations(&validate.Violation{FieldPath: "val", ConstraintId: "ignore_empty.proto2.message"}),
Expected: results.Violations(&validate.Violation{FieldPath: "val", ConstraintId: "ignore_empty.editions.message"}),
},
"proto/2023/message/explicit_presence/delimited/unset": suites.Case{
Message: &cases.IgnoreEmptyEditionsMessageExplicitPresenceDelimited{},