Remove deprecated options #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
rodaine
reviewed
Jan 27, 2025
rodaine
approved these changes
Jan 28, 2025
timostamm
reviewed
Jan 28, 2025
| @@ -27,7 +27,7 @@ message SubmitFeedbackRequest { | |||
| string email = 2 [ | |||
| // `ignore_empty` skips validation on a field if it's empty. | |||
| // The email will be not validated if it's empty. | |||
| (buf.validate.field).ignore_empty = true, | |||
| (buf.validate.field).ignore = IGNORE_IF_UNPOPULATED, | |||
There was a problem hiding this comment.
The comment above says:
// `ignore_empty` skips validation on a field if it's empty. // The email will be not validated if it's empty.
Can we update to
// `IGNORE_IF_UNPOPULATED` skips validation on a field if it's unpopulated. // The email will be not validated if it's the empty string.
?
There was a problem hiding this comment.
Yes, of course. Thanks!
timostamm
approved these changes
Jan 28, 2025
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes deprecated fields in
validate.proto, removes mention of them from relevant documentation, and replaces usages in the conformance suite with the proper up-to-date options.This is a breaking change.
Runtime PRs: