Add deprecation message to v1 and v1beta1 module #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR.
|
|
This is also one of the rare cases where |
bufdev
requested changes
Jul 6, 2024
| @@ -76,6 +76,15 @@ message Module { | |||
| (buf.validate.field).required = true, | |||
| (buf.validate.field).string.max_len = 250 | |||
| ]; | |||
| // The message of deprecating the module. Typically a message redirecting readers | |||
| // to the module that should be used instead. | |||
| string deprecation_message = 11 [(buf.validate.field).string.max_len = 255]; | |||
There was a problem hiding this comment.
We did not bring this over on purpose, thus should be dropped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds deprecation message to v1 and v1beta1 module, so that the CLI command that deprecates a module can use v1 API.