Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code owner rule that got overwritten #125

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix code owner rule that got overwritten #125

merged 1 commit into from
Jul 10, 2024

Conversation

oliversun9
Copy link
Contributor

Currently, the owner role on the first line is overwritten the second line, this PR fixes that.

From GitHub's docs:

Order is important; the last matching pattern takes the most precedence.

@oliversun9 oliversun9 requested a review from nicksnyder July 10, 2024 16:06
@github-actions GitHub Actions
Copy link

The latest Buf updates on your PR.

NameStatus
build✅ passed
lint✅ passed
format✅ passed
breaking✅ passed

nicksnyder
nicksnyder approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@nicksnyder nicksnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nicksnyder nicksnyder merged commit 098ec04 into main Jul 10, 2024
6 checks passed
@nicksnyder nicksnyder deleted the osun/update-code-owner branch July 10, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicksnyder nicksnyder nicksnyder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliversun9 @nicksnyder