Add CheckService to plugin.v1beta1 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
bufdev
approved these changes
Nov 28, 2024
|
|
||
| // Operate on Check plugins. | ||
| service CheckService { | ||
| // List rules for a given plugin commit. |
| rpc ListRules(ListRulesRequest) returns (ListRulesResponse) { | ||
| option idempotency_level = NO_SIDE_EFFECTS; | ||
| } | ||
| // List categories for a given plugin commit. |
bufdev
approved these changes
Nov 29, 2024
emcfarlane
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
CheckServicethat takes aResourceRefto allow API callers to fetch rules/categories for a plugin (latest commit on default label), label (latest commit) or commit.For a moment, I thought just maybe we could ask callers to download the wasm blob and invoke it instead, but I suspect we're not there yet. We need some way to get the rules/categories cheaply.