New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document DeleteUsers behavior #37

Merged

mfridman merged 1 commit into main from mf-comments

Nov 23, 2023

Member

mfridman commented Nov 23, 2023

Took a stab at improving the comments around the DeleteUsers behavior.

@emcfarlane does this make sense in terms of the implementation?

Duplicate ids or names are deduplicated, and only one user will be deleted
Duplicate refs that belong to the same user, id and name, are deduplicated and only one user is deleted
Both scenarios are allowed and do not surface an error


          Document DeleteUsers behavior

a86fd13

mfridman requested a review from bufdev as a code owner

November 23, 2023 16:44

bufdev approved these changes

View reviewed changes

emcfarlane approved these changes

View reviewed changes

mfridman merged commit df0f510 into main

5 checks passed

mfridman deleted the mf-comments branch

November 23, 2023 17:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet