Add buf.registry.legacy.federation.v1beta1 package #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saquibmian
reviewed
Feb 5, 2024
| (buf.validate.field).string.hostname = true | ||
| ]; | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: superflous newline here
| message Edge { | ||
| // The Node of the start of the edge. | ||
| Node from_node = 1 [(buf.validate.field).required = true]; | ||
| // The Commit of the end of the edge. |
There was a problem hiding this comment.
Suggested change
| // The Commit of the end of the edge. | |
| // The Node of the end of the edge. |
| ]; | ||
| } | ||
| // Content to upload for a given reference. | ||
| message Content { |
There was a problem hiding this comment.
Just to be clear, we will not support a workspace with modules with different registries, is that right? I'm not sure if there's someone out there who is combining federation with workspaces (e.g., a private repo that both publishes a module to buf.build for public consumption and also publishes a module to a private BSR, federating the latter dependency).
There was a problem hiding this comment.
You can't upload content for other registries correct, only depend on them.
| // An edge in the dependency graph. | ||
| message Edge { | ||
| // The Node of the start of the edge. | ||
| Node from_node = 1 [(buf.validate.field).required = true]; | ||
| // The Commit of the end of the edge. |
There was a problem hiding this comment.
Suggested change
| // The Commit of the end of the edge. | |
| // The Node of the end of the edge. |
saquibmian
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
buf.registry.legacy.federation.v1beta1package.We need to support legacy federation for a few of our early customers, and this is the easiest way for us to do so. It effectively means supporting federation on two endpoints:
GetGraphandUpload. The edits to these endpoints and their associated types will mean an API that is sufficiently different and unclean that we instead are splitting these out into their own package (and associated endpoints).