Fix use-after-free in the lua object management #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wlroots does not call `wl_list_remove(&destroy.listener_list)` after the destroy signal fires. It is the responsibility of the subscriber to handle their own wl_listener being left with an invalid link. This was an issue because it might happen that the kiwmi_object is not destroyed immediately, but only later by a lua gc handler that finally decrements the refcount to zero. We have to ensure that `kiwmi_object_destroy` can succeed. Here we first use `wl_list_remove` to unsubscribe from the signal, and then `wl_list_init` to leave the link in a valid state for `kiwmi_object_destroy`.
|
@buffet rebased my original PR that was closed due to the history rewriting. If you ever want to pick up working on the project in the future (no pressure or anything), let me know, and I can create updated versions of my other closed PRs as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #77
Wlroots does not call
wl_list_remove(&destroy.listener_list)after the destroy signal fires. It is the responsibility of the subscriber to handle their own wl_listener being left with an invalid link.This was an issue because it might happen that the kiwmi_object is not destroyed immediately, but only later by a lua gc handler that finally decrements the refcount to zero. We have to ensure that
kiwmi_object_destroycan succeed.Here we first use
wl_list_removeto unsubscribe from the signal, and thenwl_list_initto leave the link in a valid state forkiwmi_object_destroy.