Master #1
Open
Master #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install as release asset
still need to figure this out on travis
* Stop showing all these warnings As documented, `_get_cron_array()` can return `false` if there are no tasks. This generates a PHP warning in the server log, possibly multiple times each minute, like this: ``` [Wed Jun 10 08:34:43.594146 2020] [php7:warn] [pid 20160] [client 172.18.0.3:56296] PHP Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/github-updater/src/GitHub_Updater/Traits/GHU_Trait.php on line 615 ``` Added "fail fast" to stop these messages. * Update GHU_Trait.php Co-authored-by: Andy Fragen <[email protected]>
This reverts commit 5404a1c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build Code Hello World - 8