Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Increase performance of list_documents by eager loading #392

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

pajowu
Copy link
Member

@pajowu pajowu commented Nov 18, 2023

On my device with 12 documents, this brings down the load time from ~90ms to ~18ms and the number of queries performed for one request to /api/v1/documents/ from 194 to 7

@pajowu pajowu requested review from phlmn, rroohhh and anuejn November 18, 2023 21:40
@pajowu pajowu force-pushed the pajowu/db_performance branch from 69a6195 to f041eb3 Compare November 18, 2023 21:41
@pajowu pajowu force-pushed the pajowu/db_performance branch from f041eb3 to 9335359 Compare November 20, 2023 07:58
Copy link
Member

@anuejn anuejn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pajowu pajowu added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit f0c211e Nov 21, 2023
2 checks passed
@pajowu pajowu deleted the pajowu/db_performance branch November 21, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants