More rubocop cleanup, and move dev dependencies from the gemspec to t…

…he Gemfile

.rubocop.yml

@@ -8,12 +8,11 @@ Style/Documentation:
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-Metrics/LineLength:
+Layout/LineLength:
   Max: 120
-  IgnoreCopDirectives: true
 
 Metrics/BlockLength:
-  ExcludedMethods:
+  AllowedMethods:
     - configure
     - context
     - define

Gemfile

@@ -2,3 +2,12 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in bmt-ruby.gemspec
 gemspec
+
+group :development do
+  gem 'bundler', require: false
+  gem 'pry', require: false
+  gem 'rake', require: false
+  gem 'rspec', require: false
+  gem 'rubocop', require: false
+  gem 'rubocop-performance', require: false
+end

bmt.gemspec

@@ -16,12 +16,6 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
   spec.required_ruby_version = '>= 3.1'
 
-  spec.add_development_dependency 'bundler', '~> 2.1'
-  spec.add_development_dependency 'pry', '~> 0.11'
-  spec.add_development_dependency 'rake', '~> 12.3'
-  spec.add_development_dependency 'rspec', '~> 3.6'
-  spec.add_development_dependency 'rubocop', '1.65'
-
   spec.metadata = {
     'homepage_uri' => 'https://github.com/bugcrowd/bmt-ruby',
     'changelog_uri' => 'https://github.com/bugcrowd/bmt-ruby/blob/main/CHANGELOG.md',

lib/bmt.rb

@@ -43,7 +43,7 @@ def methodology_keys(version: current_version)
       DATA_DIR.join(version, 'methodologies').entries
               .map(&:basename)
               .map(&:to_s)
-              .select { |dirname| dirname =~ /json/ }
+              .grep(/json/)
               .map { |filepath| File.basename(filepath, File.extname(filepath)) }
   end
 
@@ -67,6 +67,6 @@ def json_dir_names
     DATA_DIR.entries
             .map(&:basename)
             .map(&:to_s)
-            .select { |dirname| dirname =~ /^[0-9]+\.[0-9]/ }.sort
+            .grep(/^[0-9]+\.[0-9]/).sort
   end
 end

spec/bmt/step_spec.rb

@@ -48,15 +48,15 @@
   end
 
   context 'with an executive_summary step type' do
-    let(:attributes) { methodology_json.dig('content', 'steps', 2) }
-
     subject do
       described_class.new(
         methodology:,
         attributes:
       )
     end
 
+    let(:attributes) { methodology_json.dig('content', 'steps', 2) }
+
     it 'returns the correct type' do
       expect(subject.type).to eq 'executive_summary'
     end

spec/bmt_spec.rb

@@ -5,15 +5,15 @@
     subject { described_class.versions }
 
     it 'return all of the versions in the filesystem in reverse semver order' do
-      is_expected.to eq(['2.1', '1.0'])
+      expect(subject).to eq(['2.1', '1.0'])
     end
   end
 
   describe '#current_version' do
     subject { described_class.current_version }
 
     it 'return the most recent version number for the vrt' do
-      is_expected.to eq('2.1')
+      expect(subject).to eq('2.1')
     end
   end
 
@@ -22,15 +22,15 @@
       subject { described_class.methodology_keys }
 
       it 'returns methodologies for the latest version' do
-        is_expected.to match_array(%w[website-testing outback-animal-testing])
+        expect(subject).to match_array(%w[website-testing outback-animal-testing])
       end
     end
 
     context 'with custom version' do
       subject { described_class.methodology_keys(version: '1.0') }
 
       it 'returns methodologies for the specified version' do
-        is_expected.to match_array(['website-testing'])
+        expect(subject).to match_array(['website-testing'])
       end
     end
   end

spec/spec_helper.rb

@@ -6,7 +6,7 @@
     c.syntax = :expect
   end
 
-  config.before(:each) do
+  config.before do
     # The following adds a new, test-only BMT versions
     stub_const('BMT::DATA_DIR', Pathname.new('spec/sample'))
   end