-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to rec for Token is Not Invalidated After New Token is Requested #457
Open
RRudder
wants to merge
1
commit into
master
Choose a base branch
from
not-invalidated-on-new-token
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
10 changes: 5 additions & 5 deletions
10
...tation/token_is_not_invalidated_after_new_token_is_requested/recommendations.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
# Recommendation(s) | ||
|
||
The password reset token should be invalidated after each subsequent request for a password rest from a user. Overall, the password reset implementation should conform to the following guidelines: | ||
It is best practice to invalidate old password reset tokens after each subsequent request for a password reset from a user. Overall, the password reset implementation should conform to the following guidelines: | ||
|
||
A secure password policy should be in place for the user to create a strong new password | ||
Password reset tokens should be long to protect against brute force guessing attacks, linked to an individual, invalidated after use, and have a short expiry time | ||
Passwords should be stored and transmitted securely | ||
Once a user’s password has been reset, they should be prompted to login in again through the usual login portal and not automatically signed in | ||
- A secure password policy should be in place for the user to create a strong new password | ||
- Password reset tokens should be long to protect against brute force guessinging attacks, linked to an individual, invalidated after use, and have a short expiry time | ||
- Passwords should be stored and transmitted securely | ||
- Once a user’s password has been reset, they should be prompted to login in again through the usual login portal and not automatically signed in | ||
|
||
For more information refer to the following guide relating to this vulnerability: | ||
<https://cheatsheetseries.owasp.org/cheatsheets/Forgot_Password_Cheat_Sheet.html> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"guessinging" ;)