reflect URL doesn't require a different port anymore

bugsnag · Nov 21, 2023 · 308b144 · 308b144
1 parent 6ab90ef
commit 308b144
Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/features/default/automatic_spans.feature b/features/default/automatic_spans.feature
@@ -259,7 +259,7 @@ Feature: Automatic instrumentation spans
     * a span field "parentSpanId" does not exist
     * a span field "name" equals "[HTTP/GET]"
     * a span string attribute "http.flavor" exists
-    * a span string attribute "http.url" matches the regex "http://.*:9340/reflect\?status=200"
+    * a span string attribute "http.url" matches the regex "http://.*:9339/reflect\?status=200"
     * a span string attribute "http.method" equals "GET"
     * a span integer attribute "http.status_code" is greater than 0
     * a span integer attribute "http.response_content_length" is greater than 0
@@ -284,7 +284,7 @@ Feature: Automatic instrumentation spans
     * every span field "parentSpanId" does not exist
     * a span field "name" equals "[HTTP/GET]"
     * a span string attribute "http.flavor" exists
-    * a span string attribute "http.url" matches the regex "http://.*:9340/reflect\?status=200"
+    * a span string attribute "http.url" matches the regex "http://.*:9339/reflect\?status=200"
     * a span string attribute "http.method" equals "GET"
     * a span integer attribute "http.status_code" is greater than 0
     * a span integer attribute "http.response_content_length" is greater than 0

diff --git a/features/default/manual_spans.feature b/features/default/manual_spans.feature
@@ -108,7 +108,7 @@ Feature: Manual creation of spans
     * the trace payload field "resourceSpans.0.resource" string attribute "telemetry.sdk.version" matches the regex "[0-9]\.[0-9]\.[0-9]"
     * every span field "name" equals "[HTTP/GET]"
     * every span string attribute "http.flavor" exists
-    * every span string attribute "http.url" matches the regex "http://.*:9340/reflect\?status=200"
+    * every span string attribute "http.url" matches the regex "http://.*:9339/reflect\?status=200"
     * every span string attribute "http.method" equals "GET"
     * every span integer attribute "http.status_code" is greater than 0
     * every span integer attribute "http.response_content_length" is greater than 0

diff --git a/features/fixtures/ios/Fixture/FixtureConfig.swift b/features/fixtures/ios/Fixture/FixtureConfig.swift
@@ -23,10 +23,6 @@ class FixtureConfig {
         metricsURL = mazeRunnerBaseAddress.appendingPathComponent("metrics")
         notifyURL = mazeRunnerBaseAddress.appendingPathComponent("notify")
         sessionsURL = mazeRunnerBaseAddress.appendingPathComponent("sessions")
-
-        let url = mazeRunnerBaseAddress.appendingPathComponent("reflect")
-        var components = URLComponents(url: url, resolvingAgainstBaseURL: false)!
-        components.port = 9340 // `/reflect` listens on a different port :-((
-        reflectURL = components.url!
+        reflectURL = mazeRunnerBaseAddress.appendingPathComponent("reflect")
     }
 }