Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: added absolute framework size to dangerfile #226

Merged
merged 1 commit into from
Dec 12, 2023
Merged

build: added absolute framework size to dangerfile #226

merged 1 commit into from
Dec 12, 2023

Conversation

tomlongridge
Copy link
Contributor

@tomlongridge tomlongridge commented Dec 8, 2023 •
edited
Loading

Goal

Add the same Danger reporting as bugsnag-cocoa to show absolute size of framework and summary of the net change.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

BugsnagPerformance.framework binary size did not change - 466,968 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@tomlongridge tomlongridge marked this pull request as ready for review December 8, 2023 17:29
@tomlongridge tomlongridge merged commit ff82ccb into next Dec 12, 2023
1 check passed
@tomlongridge tomlongridge deleted the tom/add-absolute-framework-size branch December 12, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstenerud kstenerud kstenerud approved these changes

@robert-smartbear robert-smartbear Awaiting requested review from robert-smartbear

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomlongridge @kstenerud