Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue causing PrivacyInfo collisions when using Cocoapods #246

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

robert-smartbear
Copy link
Contributor

Goal

Installing Bugsnag using Cocoapods was causing file collisions if the app had its own PrivacyInfo file

Design

Avoid the collisions by using resource_bundles instead of resources

Changeset

Replaces resources with resource_bundles in the podspec

Testing

Manual testing on an example app

Copy link

BugsnagPerformance.framework binary size did not change - 509,600 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +1  +0.0%      +1    [__TEXT]
  -0.0%      -1  -0.0%      -1    __TEXT,__objc_methname
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@robert-smartbear robert-smartbear merged commit 0d9e9ce into next Feb 26, 2024
21 checks passed
@robert-smartbear robert-smartbear deleted the robert/plat_11590_privacy_info_collisions branch February 26, 2024 11:14
@kstenerud kstenerud mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants