Replace tri-state types with a single type, deprecating their uses in public APIs #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the interface and avoids needing yet another tri-state type when CPU metrics are added in the next PR.
This also introduces metrics config and option objects, which will hold all of the different metric types.
Note: There is some CPU configuration stuff in here (but no implementations). It makes it easier to just split by file in this case, even though it doesn't make semantic sense between PRs.
Deprecations:
BugsnagPerformanceConfiguration .autoInstrumentRendering
has been deprecated. Please useBugsnagPerformanceConfiguration. enabledMetrics. rendering
instead.BugsnagPerformanceSpanOptions.instrumentRendering
has been deprecated. Please useBugsnagPerformanceSpanOptions.metricsOptions.rendering
instead.BSGFirstClass
type has been deprecated. Please useBSGTriState
instead.BSGInstrumentRendering
type has been deprecated. Please useBSGTriState
instead.Design
Added new
BugsnagPerformanceSpanMetricsOptions
object toBugsnagPerformanceSpanOptions
which will hold current and future metrics configuration options when creating spans.Added new
BugsnagPerformanceEnabledMetrics
object toBugsnagPerformanceConfiguration
, which controls overall whether certain metrics are collected or not.BSGTriState
replacesBSGFirstClass
andBSGInstrumentRendering
types.