Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI testing PR - DO NOT MERGE #383

Closed
wants to merge 10 commits into from
+14 −14
Closed

CI testing PR - DO NOT MERGE #383

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c618494
Isolate expectation failure
kstenerud Jan 27, 2025
cfa9403
Disable sampler thread
kstenerud Jan 27, 2025
cd95058
Turn off span processing delay
kstenerud Jan 27, 2025
156e13a
Re-enable sampler thread
kstenerud Jan 27, 2025
d3bc7e0
Partially enable delayed spans
kstenerud Jan 27, 2025
a8c2768
tweak delayed span code
kstenerud Jan 27, 2025
9de2018
turn off upload
kstenerud Jan 27, 2025
0cb0cd0
Stop BugsnagPerformance start from being called in unit tests
kstenerud Jan 27, 2025
feed6d5
x
kstenerud Jan 27, 2025
8fb5785
Undo all changes besides disabling unit tests that start bugsnag
kstenerud Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
tweak delayed span code
@kstenerud
kstenerud committed Jan 27, 2025
commit a8c276814d05566859c090c8310d267240dc5b8a
20 changes: 10 additions & 10 deletions Sources/BugsnagPerformance/Private/BugsnagPerformanceImpl.mm
View file
Original file line number Diff line number Diff line change
@@ -311,19 +311,19 @@
// Delay so that the sampler has time to fetch one more sample.
dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)((SAMPLER_INTERVAL_SECONDS + 0.5) * NSEC_PER_SEC)),
dispatch_get_global_queue(QOS_CLASS_BACKGROUND, 0), ^{
BSGLogTrace(@"BugsnagPerformanceImpl::sendCurrentBatchTask(): Delayed %f seconds, now getting system info", SAMPLER_INTERVAL_SECONDS + 0.5);
for(BugsnagPerformanceSpan *span: spans) {
auto samples = systemInfoSampler_.samplesAroundTimePeriod(span.actuallyStartedAt, span.actuallyEndedAt);
BSGLogTrace(@"BugsnagPerformanceImpl::sendCurrentBatchTask(): System info sample size = %zu", samples.size());
if (samples.size() >= 2) {
if (shouldSampleCPU(span)) {
BSGLogInfo(@"BugsnagPerformanceImpl::sendCurrentBatchTask(): Getting CPU sample attributes for span %@", span.name);
// BSGLogTrace(@"BugsnagPerformanceImpl::sendCurrentBatchTask(): Delayed %f seconds, now getting system info", SAMPLER_INTERVAL_SECONDS + 0.5);
// for(BugsnagPerformanceSpan *span: spans) {
// auto samples = systemInfoSampler_.samplesAroundTimePeriod(span.actuallyStartedAt, span.actuallyEndedAt);
// BSGLogTrace(@"BugsnagPerformanceImpl::sendCurrentBatchTask(): System info sample size = %zu", samples.size());
// if (samples.size() >= 2) {
// if (shouldSampleCPU(span)) {
// BSGLogTrace(@"BugsnagPerformanceImpl::sendCurrentBatchTask(): Getting CPU sample attributes for span %@", span.name);
// [span forceMutate:^() {
// [span internalSetMultipleAttributes:spanAttributesProvider_->cpuSampleAttributes(samples)];
// }];
}
}
}
// }
// }
// }

#ifndef __clang_analyzer__
BSGLogTrace(@"BugsnagPerformanceImpl::sendCurrentBatchTask(): Sending %zu sampled spans (out of %zu)", origSpansSize, spans.count);