Move start of delivery goroutine to configure, don't wait on signals in delivery #250
+11
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Customers reported that delivery goroutine that starts as soon as module is loading is appearing as a leak in the diagnostic tools such as
goleak. It can be safely moved toConfiguremethod.In the delivery goroutine we were also subscribing to os signals as a way to provide graceful shutdown. Unfortunately that led to main program being unable to capture signals. So our
signal.Notifyusage has to be removed.Fixes issues:
bugsnag-gois imported #249Changeset
Removed
signal.Notifyusage in delivery goroutine.Moved starting delivery goroutine to
Configuremethod.Testing
Tested using code snippets provided in issues.