add sendPayloadChecksums config option and implement Bugsnag-Integrit… #532
Conversation
| // sendPayloadChecksums is false by default unless custom endpoints are not specified | ||
| if (typeof config !== 'string' && !config.endpoint) { | ||
| configuration.sendPayloadChecksums = ('sendPayloadChecksums' in config && config.sendPayloadChecksums) || true | ||
| } |
There was a problem hiding this comment.
Not keen on this but not sure of a better way. We need to work out what config options the user passed in to determine the behaviour. const configuration = validateConfig<S, C>(config, options.schema) does more than just validate, it creates a config with all values set based on the schema, using default values if not supplied.
There was a problem hiding this comment.
right now this is the place we're performing similar manipulation on the configuration, perhaps we could refactor the validation to include this, possibly separating out validation and 'cleaning' but I think for now this is fine
Browser bundle sizeNPM build
CDN build
Code coverage
Total:
Generated against 906d8c6 on 29 November 2024 at 17:11:19 UTC |
djskinner
changed the base branch from
next
to
gingerbenw/pin-maze-runner-8.7.0
djskinner
changed the base branch from
gingerbenw/pin-maze-runner-8.7.0
to
next
| // sendPayloadChecksums is false by default unless custom endpoints are not specified | ||
| if (typeof config !== 'string' && !config.endpoint) { | ||
| configuration.sendPayloadChecksums = ('sendPayloadChecksums' in config && config.sendPayloadChecksums) || true | ||
| } |
There was a problem hiding this comment.
right now this is the place we're performing similar manipulation on the configuration, perhaps we could refactor the validation to include this, possibly separating out validation and 'cleaning' but I think for now this is fine
| } | ||
| } | ||
|
|
||
| window.isSecureContext = false |
There was a problem hiding this comment.
does this remain false for the next test? we're using beforeAll rather than beforeEach to revert this back to true
Goal
Add Bugsnag-Integrity request header (where required APIs are available) and implement the
sendPayloadChecksumscore config option to allow opting out of this behavior.Bugsnag-Integrity headers are set by default unless the
endpointconfiguration option is set, in which case they are disabled. This behavior can be overriden with the newsendPayloadChecksumsconfig option.Design
sendPayloadChecksumswas chosen to avoid possible CORS issues where custom endpoints are being used and they are not configured to accept the newBugsnag-Integrityin requests.Changeset
sendPayloadChecksumscore config optionBugsnag-Integrityin delivery-fetchTesting