Throw errors from attach when native SDK is not available #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailable or has not been started
gingerbenw
approved these changes
Jan 22, 2025
Base automatically changed from
PLAT-13414/native-integration-tests
to
integration/rn-native-integration
January 22, 2025 17:33
yousif-bugsnag
merged commit 9c595f0
into
integration/rn-native-integration
37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Currently when
attachis called, if the JS SDK cannot communicate with the native Android/Cocoa SDK, either because it hasn't been installed, is incompatible, or hasn't been started, we log a warning and noop.But that means we don't call
starton the JS client - so the native span delegation will be disabled, but customers can still then create JS spans, and these will just accumulate in memory (as they would if you start a span beforestartis called).Instead, we should fail loudly and throw an error as this means something is misconfigured and the SDK cannot be started.
Also removed some unnecessary null checks around
NativeBugsnagPerformance(since we now have a JS fallback)