-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for integration with native Android and Cocoa Performance SDKs #573
Merged
+2,687
−288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync integration branch with next
Loading status checks…
Loading status checks…
…dependencies
Loading status checks…
Add support for attaching to native performance SDKs
# Conflicts: # test/react-native/features/fixtures/scenario-launcher/android/build.gradle
Loading status checks…
Sync integration branch with next
Loading status checks…
* feat(react-native): support for starting native spans on android * refactor(react-native): add ReactNativeSpanContext class * refactor(react-native): use constants for hex radix and trace id midpoint values * fix(react-native): update `isNativePerformanceAvailable` runtime check
Loading status checks…
Loading status checks…
feat(react-native): support for starting native spans on ios
Loading status checks…
Loading status checks…
Loading status checks…
feat(react-native): support ending native android spans
Loading status checks…
feat(react-native): support ending native ios spans
Loading status checks…
…tory Add ReactNativeSpanFactory class
Loading status checks…
React Native platform extensions improvements
Loading status checks…
Support discarding native spans in Turbo Module
Loading status checks…
…ached (#556) * feat(react-native): add turbo module initialise method avoid repeated calls to the native module by calling initialise once on module load and getting all of the native settings at once * feat(react-native): delegate first class spans to native SDK * feat(react-native): run onSpanEnd callbacks when processing native spans * test(react-native): add span factory unit tests * refactor: move onSpanEndCallback logic out of batch processor * revert: undo initialise method This partially reverts commit 0820748. * test(react-native): update native integration e2e test * fix(react-native): preserve sampling attribute for native Android spans * refactor(core): configure span factory as early as possible and move early spans logic into span factory * test(react-native): test custom attributes on native spans * refactor(react-native): always use discard end time when discarding spans * fix(react-native): fix platform check
Loading status checks…
…ive SDK
Loading status checks…
…ering-metrics Do not delegate automatic navigation spans to native SDK
Loading status checks…
…for more than one hour (#560) * feat(react-native): periodically clean up native spans that are open for more than one hour * refactor(react-native): use a main-thread handler for android cleanup task * refactor(react-native): move span end logic out of synchronized block
# Conflicts: # packages/platforms/react-native/__mocks__/react-native.ts # packages/platforms/react-native/android/src/main/java/com/bugsnag/android/performance/NativeBugsnagPerformanceImpl.java # packages/platforms/react-native/android/src/newarch/java/com/bugsnag/android/performance/BugsnagReactNativePerformance.java # packages/platforms/react-native/android/src/oldarch/java/com/bugsnag/android/performance/BugsnagReactNativePerformance.java # packages/platforms/react-native/ios/BugsnagReactNativePerformance.mm # packages/platforms/react-native/lib/NativeBugsnagPerformance.ts # packages/platforms/react-native/lib/client.ts
Loading status checks…
Sync integration branch with next
Sync integration branch with next
Loading status checks…
…ailable or has not been started
Loading status checks…
Add Native integration tests to full CI pipeline
Loading status checks…
Throw errors from attach when native SDK is not available
gingerbenw
approved these changes
Jan 23, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Merge down the RN native integration branch to next ready for release.