Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin: use Go type wrappers to avoid declaring Go methods on C types. #163

Merged
merged 4 commits into from
Aug 10, 2023
Merged

darwin: use Go type wrappers to avoid declaring Go methods on C types. #163

merged 4 commits into from
Aug 10, 2023

Commits on Aug 10, 2023

  1. darwin: use Go type wrappers to avoid declaring Go methods on C types. 

    This is needed starting with Go 1.21 due to stricter enforcement of rules
about adding methods to existing types, now including C types.

See golang/go#60725 for further details.

Signed-off-by: deadprogram <[email protected]>
    @deadprogram @cmaglie
    deadprogram authored and cmaglie committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    80a3721 View commit details
    Browse the repository at this point in the history

  2. darwin: moved type definitions near methods definition

    @cmaglie
    cmaglie committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    c1ded5f View commit details
    Browse the repository at this point in the history

  3. darwin: wrap cgo-types directly (without using a struct) 

    This makes easier the boxing/unboxing of the wrapped types.
    @cmaglie
    cmaglie committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    c9a9ed4 View commit details
    Browse the repository at this point in the history

  4. removed leftover print

    @cmaglie
    cmaglie committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    1e13b2f View commit details
    Browse the repository at this point in the history