Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic dependency resolver. Added dependency resultion strategies. #13

Closed
wants to merge 2 commits into from

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 15, 2023

  • The dependency resolver is now based on generics (the caller is no more forced to cast his concrete types into the Dependency and Release interfaces).

  • The resolution strategies have been implemented:

    // MinimumVersionRequiredStrategy is a resolution strategy where the minimum
    // required version is taken from the available set. The computed solution
    // is stable, running the algorithm again will produce the same solution even
    // if new releases becomes available in the meantime.
    const MinimumVersionRequiredStrategy ResolutionStrategy = iota
    
    // MaximumVersionAvailableStrategy is a strategy where the latest available
    // version is taken from the available set. The computed solution will have
    // all the latest possible versions of the libraries. The solution is not
    // stable, it will probably require a lock file to be able to reproduce it
    // at a later time.
    const MaximumVersionAvailableStrategy ResolutionStrategy = iota

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #13 (9088832) into master (518e126) will decrease coverage by 2.39%.
The diff coverage is 66.07%.

@@             Coverage Diff             @@
##            master      #13      +/-   ##
===========================================
- Coverage   100.00%   97.61%   -2.39%     
===========================================
  Files           10       10              
  Lines          761      795      +34     
===========================================
+ Hits           761      776      +15     
- Misses           0       18      +18     
- Partials         0        1       +1     
Impacted Files Coverage Δ
resolver.go 78.40% <66.07%> (-21.60%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@per1234 per1234 added the enhancement New feature or request label Mar 18, 2023
@cmaglie
Copy link
Member Author

cmaglie commented Nov 22, 2023

Superseded by #19
Strategies need to be re-implemented.

@cmaglie cmaglie closed this Nov 22, 2023
@cmaglie cmaglie deleted the generic-dep-resolver branch November 22, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants