Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider '=' constraint implicit if operator is missing [experimental] #7

Closed
wants to merge 3 commits into from

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 26, 2022

This allows parsing of constraints like 1.0.0 as =1.0.0.
Any other combination is allowed too 1.0.0 && 1.0.1 now means =1.0.0 && =1.0.1

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #7 (17ed0f5) into master (2f82020) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files           9        9           
  Lines         651      660    +9     
=======================================
+ Hits          650      659    +9     
  Misses          1        1           
Impacted Files Coverage Δ
constraints.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f82020...17ed0f5. Read the comment docs.

Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding another row to the table in the readme:

diff --git a/README.md b/README.md
index 1419c81..d23c58c 100644
--- a/README.md
+++ b/README.md
@@ -64,6 +64,7 @@ constraints would resolve as follows:
 | Constraint                       | Resolution |
 | -------------------------------- | ---------- |
 | `=1.0.0`                         | `1.0.0`    |
+| `1.0.0`                          | `1.0.0`    |
 | `>1.0.0`                         | `2.1.0`    |
 | `>=1.0.0`                        | `2.1.0`    |
 | `<2.0.0`                         | `1.0.0`    |

I think that would provide sufficient documentation coverage of the new capability.

@cmaglie
Copy link
Member Author

cmaglie commented May 29, 2022

Superseded by #10

@cmaglie cmaglie closed this May 29, 2022
@cmaglie cmaglie deleted the expand_constraint_parser branch May 29, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants