forked from udacity/AIND-Isolation
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from udacity:master #1
Open
pull
wants to merge
54
commits into
bugzpodder:master
Choose a base branch
from
udacity:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor Board class to use more efficient representation.
Randomize the order of legal moves list to prevent accidental advantage against low-fidelity heuristics.
Added standard template for .gitignore
- eliminate unused import - extend timeout for all tests to 60s
State the relationship between CustomPlayer parameters: search_depth …
Create .gitignore
Provide a template for students rather than full test suite. The project assistant uses tests that would reveal the solution, so they are kept private. The updated tests should include more useful debugging information than the old local tests provided.
…valuation The old tournament structure did not correct for potential advantages due to random starting positions (the test and reference agents played independent games). The updated tournament uses identical starting conditions for every match that the test agents play, which better controls for starting position bias. - improve the tournament report format - report on all three custom heuristic agents - update the tournament agent list (and add center board heuristic)
…y’re included in the zip file for submission.
…running HTTP server in python 3
Removed dialogue for non-competition submission
Display the board before the human player has to select a move
Jamesandersen patch 1
The center score heuristic now uses the coordinates of the board center to calculate the relative distance of the player.
… make it work as is.
Print statements were hard-coded, making it hard to run the tournament with another number of cpu/test agents. Now it computes the printed strings from the lists of agents.
Added import statements in the sample code in README.md to make it work as a standalone example.
Format printed strings programmatically based on number of agents
The previous warning implied that forfeits were coming from the ID search agent specifically. In fact, forfeits are also counted and reported for the `MinimaxPlayer` which does not use ID.
Fix misleading warning message for forfeits
Use default python unit test command: `python -m unittest` References: - Test-Driven Python Development, by Siddharta Govindaraj https://www.amazon.com/dp/B00VQF59D6 - The Hitchhiker's Guide to Python. http://python-guide.readthedocs.io/en/latest/writing/tests/
Create unit test module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )