Manage integration button #141
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orouz
commented
Feb 22, 2022
Comment on lines
154
to
155
| <EuiButtonEmpty | ||
| href={pagePathGetters.edit_integration({ policyId: '1', packagePolicyId: '2' })[1]} |
There was a problem hiding this comment.
this is how we get the href in general
obviously now it's just placeholders. when benchmark page is added this info will be available
orouz
force-pushed
the
manage_integration_btn
branch
from
53565de
to
96191ba
Compare
orouz
force-pushed
the
manage_integration_btn
branch
from
96191ba
to
c608dec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds a button to navigate to the integration instance edit page
it assumes later on we'll have the
policyIdandpackagePolicyIdparams to replace the placeholdersissue: https://github.com/elastic/security-team/issues/3028
includes code from #121