Optimize ockam node create #8755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SanjoDeundiak
commented
Jan 15, 2025
•
SanjoDeundiak
commented
- Move tokio Runtime creation to the earliest possible during ockam command execution
- Avoid creating tokio Runtime more than once
- Remove Runtime singletin inside ockam_node create
- Remove most of the blocking calls
- Simplify commands to support only async execution
- Add timeout to Tcp connections
- Optimize node creation by replacing readiness check from polling to TCP callback
- Move logging setup to the earliest possible
- Simplify CliState
SanjoDeundiak
force-pushed
the
sanjo/node_callback
branch
9 times, most recently
from
357e149 to
bb8b008
Compare
SanjoDeundiak
changed the title
Runtime in a predictable way and reuse it
SanjoDeundiak
force-pushed
the
sanjo/node_callback
branch
8 times, most recently
from
ff99ca4 to
e53013f
Compare
SanjoDeundiak
force-pushed
the
sanjo/node_callback
branch
2 times, most recently
from
0e286be to
92b1064
Compare
SanjoDeundiak
changed the title
SanjoDeundiak
force-pushed
the
sanjo/node_callback
branch
from
92b1064 to
3b24477
Compare
SanjoDeundiak
force-pushed
the
sanjo/node_callback
branch
5 times, most recently
from
320c205 to
5a48ccc
Compare
SanjoDeundiak
force-pushed
the
sanjo/node_callback
branch
17 times, most recently
from
a6f1f2b to
946b269
Compare
adrianbenavides
approved these changes
Feb 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
- create tokio `Runtime` in a predictable way and reuse it - rework `Command` usage - add `no_logging` flag to the node - optimize node startup - replace readiness poll with a callback
SanjoDeundiak
force-pushed
the
sanjo/node_callback
branch
from
946b269 to
8c8d7f2
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.