fix(rust): add missing branding replacements in ockam_command #8785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adrianbenavides
commented
Feb 3, 2025
•
adrianbenavides
commented
- replace hardcoded binary names and command names (e.g. when spawning a background node) with their corresponding compile env vars
- replace command names with their custom names in output, docs, and help texts
adrianbenavides
force-pushed
the
adrian/add-missing-branding-replacements
branch
2 times, most recently
from
ee4a34e to
86ad15c
Compare
etorreborre
reviewed
Feb 4, 2025
etorreborre
previously approved these changes
Feb 4, 2025
adrianbenavides
force-pushed
the
adrian/add-missing-branding-replacements
branch
from
86ad15c to
371f8db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.