-
Notifications
You must be signed in to change notification settings - Fork 2
[email protected] #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…e-builder into development # Conflicts: # dist/index.js.map
roll back adding codesign flags for keychain access
renamed some inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the Unity-Xcode builder to v1.3.0 by adding new inputs for macOS notarization and test group support, renaming certificate‐related inputs, and refining the notarization, signing, and export workflows.
- Added inputs for test groups, archive type, and Developer ID certificates
- Renamed certificate inputs and improved notarization and credential cleanup flows
- Updated polling for valid builds and adjusted related GitHub workflow configurations
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
src/xcode.ts | Updated notarization checks, signing identity usage, and export/archive logic for macOS builds. |
src/XcodeProject.ts | Added new project properties (isSteamBuild, archiveType, notarize). |
src/AppleCredential.ts | Refactored credentials handling with renamed inputs and enhanced certificate import logic. |
src/AppStoreConnectClient.ts | Increased polling retries and added beta group support for test builds. |
package.json | Bumped version to 1.3.0. |
action.yml | Updated input descriptions, default values, and added deprecation messages. |
README.md | Revised input documentation reflecting the new naming and usage guidelines. |
.github/workflows/validate.yml | Adjusted environment variable settings and build export options. |
.github/workflows/update-release-tags.yml | Minor YAML update to tag push syntax. |
Comments suppressed due to low confidence (1)
src/xcode.ts:377
- [nitpick] The renaming from 'signingIdentity' to 'manualSigningIdentity' must be consistently reflected across all related code paths and documentation to avoid ambiguity. Ensure that all references (including default assignments and error messages) are updated accordingly.
if (manualSigningIdentity) {
test-groups
: One or more test groups to automatically add to the build when uploading to TestFlight. When using multiple groups, separate them with commas.archive-type
: The archive type to use when exporting macOS applications when not uploading to the App Store. Can be one ofapp
orpkg
.developer-id-application-certificate
: TheDeveloper ID Application
certificate encoded as base64 string. Used for signing macOS app bundles when not uploading to app store.developer-id-application-certificate-password
: The password for theDeveloper ID Application
certificate.developer-id-installer-certificate
: TheDeveloper ID Installer
certificate encoded as base64 string. Used for signing installer packages for macOS applications.developer-id-installer-certificate-password
: The password for theDeveloper ID Installer
certificate.certificate
->manual-signing-certificate
certificate-password
->manual-certificate-password
signing-identity
->manual-signing-identity