Add settings for controlling CORS and changing reverse proxy target #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found when deploying bb-portal in some situations that the configurability of the application was lacking. The problems I had was that the it was nessecary to proxy the frontend through the backend due to CORS problems, and that the proxying was not configurable.
This PR:
allowedOrigins
configuration option from the gRPC-proxies to the root of the configuration, and also uses the setting to allow for CORS on the main HTTP server.Note that this brings with it two breaking changes:
allowedOrigins
is not configured. I think this is better since we this way have secure defaults, but I can change the behavior to the reverse if you think that is better.