Skip to content

Commit

Permalink
enterprise/ingress: remove condition around grpc_set_header (#119)
Browse files Browse the repository at this point in the history
`if` directive is not allowed inside the main http block.
Revert to the previous logic where we set these headers
unconditionally.
  • Loading branch information
sluongng authored Jan 24, 2025
1 parent 1701a6a commit bd8dfd0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
2 changes: 1 addition & 1 deletion charts/buildbuddy-enterprise/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
description: BuildBuddy Enterprise
name: buildbuddy-enterprise
version: 0.0.334 # Chart version
version: 0.0.335 # Chart version
appVersion: 2.123.0 # Version of deployed app
keywords:
- buildbuddy
Expand Down
12 changes: 3 additions & 9 deletions charts/buildbuddy-enterprise/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -156,23 +156,17 @@ ingress:
default "";
~serialNumber=(?<api_key>[^,]*) "api_key_from_cert";
}
if ($cert_auth_type != "") {
grpc_set_header x-buildbuddy-auth-type $cert_auth_type;
}
grpc_set_header x-buildbuddy-auth-type $cert_auth_type;
map $host $host_auth_type {
default "";
~^(?<api_key>[^@]*)@ "api_key_from_host";
}
if ($host_auth_type != "") {
grpc_set_header x-buildbuddy-auth-type $host_auth_type;
}
grpc_set_header x-buildbuddy-auth-type $host_auth_type;
map $http_x_buildbuddy_api_key $api_key {
default "";
"~." $http_x_buildbuddy_api_key;
}
if ($api_key != "") {
grpc_set_header x-buildbuddy-api-key $api_key;
}
grpc_set_header x-buildbuddy-api-key $api_key;
# metrics:
# enabled: true
# service:
Expand Down

0 comments on commit bd8dfd0

Please sign in to comment.