CI: no local actions #7166
Merged
CI: no local actions #7166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
force-pushed
the
sluongng/no-local-actions
branch
from
ccb0e4b to
c574704
Compare
fmeum
approved these changes
Aug 6, 2024
fmeum
approved these changes
Aug 6, 2024
Since we are mostly doing Build without the Bytes, running this action locally would actually cause downloads to happen and slow down our build.
sluongng
force-pushed
the
sluongng/no-local-actions
branch
from
23050f9 to
788a3fa
Compare
sluongng
added a commit
that referenced
this pull request
Aug 8, 2024
While working on #7166, I discovered that clicking on `local` actions in the execution log card would crash our UI. This is because local spawn entry does not have `digest` and thus, render the entries in the card with `href=/invocation/<uuid>$#action`, and clicking on it would cause our browser to crash. Don't render the invalid URL here.
sluongng
added a commit
that referenced
this pull request
Aug 8, 2024
While working on #7166, I discovered that clicking on `local` actions in the execution log card would crash our UI. This is because local spawn entry does not have `digest` and thus, render the entries in the card with `href=/invocation/<uuid>$#action`, and clicking on it would cause our browser to crash. Don't render the invalid URL here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to change all the forced-local actions to remote-able actions.
It should improve our Build without the Bytes setup and reduce the amount of artifacts downloaded locally.
After this is applied, we still download a few data from each build:
The remaining data could still be significant in some cases, such as a change that invalidates a lot of tests with large logs.
The fix for these most likely will have to come from Bazel upstream.