Don't use container runtimes bundled with podman-static release #7352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
force-pushed
the
crun-downgrade
branch
4 times, most recently
from
b9bb7df
to
ca599ae
Compare
bduffany
force-pushed
the
crun-downgrade
branch
from
ca599ae
to
15d2366
Compare
iain-macdonald
approved these changes
Sep 3, 2024
vadimberezniker
approved these changes
Sep 3, 2024
bduffany
force-pushed
the
crun-downgrade
branch
4 times, most recently
from
210f8b6
to
e171700
Compare
bduffany
force-pushed
the
crun-downgrade
branch
from
e171700
to
758e5d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the memory corruption bug ("corrupted size vs. prev_size") mentioned in https://github.com/buildbuddy-io/buildbuddy-internal/issues/3631
It turns out that
podman-staticincludes its own versions ofcrunandruncunder/usr/local/bin, which has higher precedence in PATH than the ones we provision under /usr/bin. So when upgrading to the latestpodman-staticrelease, we inadvertently upgradedcrunto version 1.16.1, which has a double-free bug. This was causing the "corrupted size vs. prev_size" errors we were seeing in some teed actions.The double-free bug won't be fixed until 1.16.2, so this PR effectively just downgrades us to 1.15 until 1.16.2 is available.
Related issues: https://github.com/buildbuddy-io/buildbuddy-internal/issues/3631