Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore functionality on 3.x and contribution #265

Open
parshav opened this issue Jul 16, 2019 · 1 comment
Open

Ignore functionality on 3.x and contribution #265

parshav opened this issue Jul 16, 2019 · 1 comment

Comments

@parshav
Copy link

parshav commented Jul 16, 2019

Hey, so Im setting up the 3.x version of mainframer, and notice that the ignore.yml is not respected by mainframer. Looking further, I noticed that Ignore::from_working_dir() uses three different files, unlike what is specified in the Readme.
Although I can go in myself and modify the changes, is this the approach the tool will take henceforth ? Is there a board / scope of work for 3.x that I could possibly help out with as well?
Thanks !

@artem-zinnatullin
Copy link
Contributor

Yeah, sorry about that, we've updated some docs ahead of code. For now you should define .mainframer/ignore file as it was in 2.x

If you want to update the docs to reflect current state, I'd happily accept that change and then would update them again once we migrate all configs to YAML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants