This repository was archived by the owner on Jul 30, 2019. It is now read-only.
Build apps in sequence when parallel=false #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 19, 2017 05:46
- adds unit tests for `buildAll` - changes bundle events to chained promises
digitil
changed the title
|
Fixes #1 I changed the mechanism for determining when a bundle is finished from events to promises and used the promise chain to ensure that these are always called in sequence |
digitil
commented
Feb 20, 2017
| if (onDone) { | ||
| execOnDoneAfterFinished(map('bundle', bundles)); | ||
| } | ||
| bundles.forEach(bundlerTools.writeBundle); |
There was a problem hiding this comment.
this forEach meant that writeBundle would be called (almost) concurrently for all bundles, which could be many
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.