-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,10 @@ if [[ -n "${BUILDKITE_PLUGIN_GOLANG_IMPORT:-}" ]]; then | |
# Now checkout into the correct import location within that gopath | ||
export BUILDKITE_BUILD_CHECKOUT_PATH="$GOPATH/src/$BUILDKITE_PLUGIN_GOLANG_IMPORT" | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
toolmantim
Author
Contributor
|
||
echo "BUILDKITE_BUILD_CHECKOUT_PATH=$BUILDKITE_BUILD_CHECKOUT_PATH" | ||
|
||
# Add golang bin commands to path | ||
export PATH="$PATH:$GOPATH/bin" | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
toolmantim
Author
Contributor
|
||
echo PATH="$PATH" | ||
else | ||
echo "+++ :golang: No 'import' option specified" | ||
exit 1 | ||
|
2 comments
on commit 02e95b2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearly I am not qualified to write a Golang plugin! 😂
I’ll read up and do some testing, and fix those two things. Thanks for the catch @lox! 🙏🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, they were probably nitpicks, and I think you were correct!
GOPATH is a colon delimited collection of paths, wonder if we should test for this?