⚡️ perf: optimize pipeline filtering by repository in API calls #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace local filtering with repository-specific API requests to reduce data transfer and improve performance when filtering pipelines by repository URLs. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Thanks @abhishekmukherg! This kind of optimisation was on our roadmap so we'll take a look and see if at can merge it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace local filtering with repository-specific API requests to reduce data transfer and improve performance when filtering pipelines by repository URLs.
I have absolutely no idea if this is a good thing or not in the grand scheme of things, but as it stands now,
bk build viewis useless to me as it tries to enumerate every pipeline we own at our organization, which is... a lot. This leverages the repo url of the current repository to filter what's being listed, which makes it a LOT faster.I can view this as being problematic if the use case involves forks? But I figured I'd throw this up there in case it sounds interesting to anyone.