-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go test runner #231
base: main
Are you sure you want to change the base?
Go test runner #231
Conversation
Hey @lox! Thanks for this 😁 We'll give it a go (🥁 ) locally and send back any thoughts! |
I ran into all sorts of problems getting it to actually run and lack of viz into the current pipelines, etc. Lemme know if there is interest over there for a chat, I'm happy to keep contributing on the go side. |
Hi @lox Thanks again for submitting this PR! We had a small mobbing session today to see if we could get it running with the tests in this repository but ran into a few problems. We tried running the client against a local server (with the Go support change outlined below), but were unable to get things working. The command we used was
We've added support server-side for Go runners, so you should be able to run this on your prod pipelines shortly to verify that everything is working. Would you be able to give this a try and report back if things are working? If you want a hand getting set up then we can schedule a call. Cheers! |
Thanks, can you help me understand what this means? |
If you have a test suite collecting Go test results (using gotestsum or some other means to send JUnit data to Test Engine), you can run To run this locally, you could export the following env vars after substituting
NB You'll need to change the |
Hey @lox just checking in about this! Were the extra instructions helpful? We could also make a time to set up a zoom or something :) or we could try and get it working more on our end if you don't wanna keep pushing this along! |
I'll give it a shot this week! |
Hi @lox I’ve looked into this and discovered some complexities/limitations in splitting Go tests by test file. Currently, the Test Engine lacks the capability to extract test file information from a Go test result. This means that our server can’t create an optimal (evenly partitioned) splitting by test file, unlike other test frameworks. We’re considering splitting Go tests by test or package, which needs a different implementation compared to other test frameworks. To do that, we first need to change our server side implementation to enable us to create an optimal partition in a scalable way. We'll let you know when we have more information. |
It's quite unclear to me what aspects are server-side and what are in this client, is there docs somewhere on what that boundry is? |
Description
Implement a go test runner
Changes
Adds a go test runner, with test listing, splitting, etc.
Testing
Pretty extensive go tests.