Skip to content

Commit

Permalink
Merge pull request #1018 from buildo/1014-dropdown_typings_for_option…
Browse files Browse the repository at this point in the history
…renderer

#1014: Dropdown typings for `optionRenderer` and `optionGroupRenderer` are slightly broken (closes #1014)
  • Loading branch information
francescogior authored Aug 2, 2017
2 parents 396ce94 + 77494b5 commit 054fb3f
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/Dropdown/Dropdown.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ interface DropdownMenuRendererProps extends MenuRendererProps {
groupByKey?: string,
optionClassName: string,
optionComponent: JSX.Element,
optionRenderer: (option: Option) => JSX.Element,
optionGroupRenderer: (title: string) => JSX.Element
optionRenderer: (option: Option, i: number) => React.ReactNode,
optionGroupRenderer: (title: string) => React.ReactNode
valueKey: any
}

Expand All @@ -37,13 +37,13 @@ export type DropdownProps = {
menuPosition?: 'top' | 'bottom',
menuRenderer?: (menuItem: DropdownMenuRendererProps) => React.ReactElement<any>, // TODO: t.ReactChildren
groupByKey?: string,
optionGroupRenderer?: (title: string) => JSX.Element, // TODO: t.ReactChildren
optionGroupRenderer?: DropdownMenuRendererProps['optionGroupRenderer'],
placeholder?: string | React.ReactElement<any>, // TODO: t.maybe(t.union([t.String, t.ReactElement]))
noResultsText?: string,
allowCreate?: boolean,
addLabelText?: string,
valueRenderer?: (option: Option) => JSX.Element, // TODO: t.ReactChildren
optionRenderer?: (option: Option) => JSX.Element, // TODO: t.ReactChildren
optionRenderer?: DropdownMenuRendererProps['optionRenderer'],
delimiter?: string,
onInputChange?: (inputValue: string) => void,
onFocus?: FocusEventHandler<HTMLDivElement>,
Expand Down

0 comments on commit 054fb3f

Please sign in to comment.