-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fully qualified image names #702
base: main
Are you sure you want to change the base?
Conversation
…rectory Signed-off-by: Hiroshi Hayakawa <[email protected]>
Signed-off-by: Hiroshi Hayakawa <[email protected]>
@@ -42,8 +42,8 @@ Stacks are used by [builders][builder] and are configured through a builder's | |||
|
|||
[stack] | |||
id = "com.example.stack" | |||
build-image = "example/build" | |||
run-image = "example/run" | |||
build-image = "docker.io/example/build" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this image need a registry? I think this may meet your criteria of only being used in the local environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my understanding, this image means it is pulled from a remote registry to be used as a build environment, so I thought it should be specified with the registry name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be okay, the daemon will happily accept some-image
and index.docker.io/some-image
interchangeably.
Side note, while docker.io/some-image
is correct, all of our code will resolve a registry-less image name to index.docker.io/<image>
so I think using the fully qualified domain would be clearer.
Signed-off-by: Hiroshi Hayakawa <[email protected]>
4fc4c20
to
8a4c3a5
Compare
Signed-off-by: Hiroshi Hayakawa <[email protected]>
Signed-off-by: Hiroshi Hayakawa <[email protected]>
Signed-off-by: Hiroshi Hayakawa <[email protected]>
Addresses the buildpacks/pack#1218, specifically the modifications to the documentation.
This PR changes the container image names used in the document to fully qualified names. Currently, I'm adopting the following policies:
registry.example.com
for the hostname andexample
for the organization name.registry.example.com/example/my-app
for-buildpack-authors/concepts/lifecycle-phases.md
I usedregistry.fake
as hostname. Because the name is already used in other parts of the page including terminal recordings, and it's too time-consuming to fix.docker.io/ubuntu:jammy
instead ofubuntu:jammy
And I fixed some technical errors like typos found when I read through the documents.