Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically determine valid lifecycle #2328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Dynamically determine valid lifecycle #2328

wants to merge 1 commit into from
+68 −17

Conversation

modulo11
Copy link
Contributor

@modulo11 modulo11 commented Jan 31, 2025 •
edited
Loading

Summary

Implements #2163.

It downloads the default lifecycle image (docker.io/buildpacksio/lifecycle) and determines the supported operating systems and architecture from that. An error is now thrown if neither of them is supported

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #2163

@github-actions github-actions bot added this to the 0.37.0 milestone Jan 31, 2025
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jan 31, 2025
@modulo11 modulo11 force-pushed the validate-lifecycle-image branch from 06ba741 to bc08e37 Compare January 31, 2025 11:03
@jjbustamante jjbustamante removed this from the 0.37.0 milestone Feb 21, 2025
@modulo11 modulo11 force-pushed the validate-lifecycle-image branch 3 times, most recently from a78c6c8 to 9a76685 Compare March 3, 2025 15:42
@modulo11 modulo11 marked this pull request as ready for review March 3, 2025 15:43
@modulo11 modulo11 requested review from a team as code owners March 3, 2025 15:43
@github-actions github-actions bot added this to the 0.37.0 milestone Mar 3, 2025
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Mar 3, 2025
@natalieparellano
Copy link
Member

This needs a lint

@jjbustamante
Copy link
Member

jjbustamante commented Mar 4, 2025 •
edited
Loading

This needs a lint

@natalieparellano @modulo11 I fixed this one updating imgutil to use go 1.23

@jjbustamante jjbustamante modified the milestones: 0.37.0, 0.38.0 Mar 5, 2025
@modulo11 modulo11 force-pushed the validate-lifecycle-image branch from 9a76685 to add3e05 Compare March 5, 2025 07:11
@github-actions github-actions bot modified the milestones: 0.38.0, 0.37.0 Mar 5, 2025
@jjbustamante jjbustamante modified the milestones: 0.37.0, 0.38.0 Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.38.0
Development

Successfully merging this pull request may close these issues.

Validation of lifecycle image os/arch should be more flexible
3 participants
@modulo11 @natalieparellano @jjbustamante