Distribution Specs (v3) - Builder Distribution Spec #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimil749
force-pushed
the
distribution-builder
branch
from
e383f7e to
a6c81c4
Compare
|
Resolved the merge conflict. It'd be great to have a review for this. |
sclevine
requested changes
Nov 29, 2021
jkutner
reviewed
Nov 30, 2021
jkutner
reviewed
Nov 30, 2021
jromero
reviewed
Dec 1, 2021
jromero
reviewed
Dec 6, 2021
Signed-off-by: Jimil Desai <[email protected]>
Signed-off-by: Jimil Desai <[email protected]>
Signed-off-by: Jimil Desai <[email protected]>
Signed-off-by: Jimil Desai <[email protected]>
Signed-off-by: Jimil Desai <[email protected]>
jimil749
force-pushed
the
distribution-builder
branch
from
bd5ab82 to
f6c99de
Compare
Signed-off-by: Jimil Desai <[email protected]>
Signed-off-by: Jimil Desai <[email protected]>
jromero
approved these changes
Jan 3, 2022
natalieparellano
approved these changes
Jan 3, 2022
hone
approved these changes
Jan 5, 2022
Signed-off-by: Jimil Desai <[email protected]>
Signed-off-by: Jimil Desai <[email protected]>
nebhale
approved these changes
Jan 6, 2022
jkutner
approved these changes
Jan 7, 2022
jabrown85
approved these changes
Jan 7, 2022
ekcasey
reviewed
Jan 19, 2022
- Rename `io.buildpacks.buildpackages` => `io.buildpacks.buildpack`
- Remove `io.buildpacks.builder.metadata`.`buildpacks`
- Duplicate data from `io.buildpacks.buildpack.layers`
- Unset `io.buildpacks.buildpack.metadata` on builder
- Update TOC
Signed-off-by: Javier Romero <[email protected]>
|
@ekcasey can I get a re-review? |
sclevine
approved these changes
Feb 11, 2022
ekcasey
approved these changes
Feb 15, 2022
|
@buildpacks/core-team - can someone hit the merge button? |
|
@jromero done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists the artifact format and the delivery mechanism for Buildpacks' Builder Image.
For the most part, the builder references the buildpacks components i.e. buildpackage, build-image and the lifecycle.
Signed-off-by: Jimil Desai [email protected]
PS: Links to lifecycle and build-image are broken, I'll fix that once those PRs are merged!